Fix loadSavedModel for DBFS #13784
Merged
Fix loadSavedModel for DBFS #13784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maziyarpanahi
approved these changes
May 10, 2023
maziyarpanahi
changed the base branch from
master
to
release/442-release-candidate
maziyarpanahi
merged commit b8a8cb1
into
JohnSnowLabs:release/442-release-candidate
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug, where loadSavedModel throws an error, when trying to access files via DBFS.
It seems like in a previous commit for a new feature,
ResourceHelper'spathvariable changed types fromPathtoOption[Path]. Calling thetoStringmethod on this type will instead convert theOptioninstead of the actual path. This was fixed withpath.get.How Has This Been Tested?
Tested on Databricks and it is working again as expected.
Screenshots (if appropriate):
Types of changes