Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARKNLP-809: Add warning to ForZeroShot annotators #13798

Conversation

DevinTDHa
Copy link
Member

@DevinTDHa DevinTDHa commented May 16, 2023

Description

This PR adds a warning to ZeroShot annotators. As the annotators loop through the provided labels, the more labels have, the longer the process will take.

Additionally

Motivation and Context

How Has This Been Tested?

No Code Changes

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DevinTDHa DevinTDHa added documentation DON'T MERGE Do not merge this PR labels May 16, 2023
@DevinTDHa DevinTDHa self-assigned this May 16, 2023
@coveralls
Copy link

coveralls commented May 16, 2023

Pull Request Test Coverage Report for Build 5055186599

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 65.844%

Files with Coverage Reduction New Missed Lines %
src/main/scala/com/johnsnowlabs/nlp/annotators/sentence_detector_dl/SentenceDetectorDLModel.scala 2 82.72%
Totals Coverage Status
Change from base Build 4945586143: 0.0%
Covered Lines: 8640
Relevant Lines: 13122

💛 - Coveralls

@maziyarpanahi maziyarpanahi changed the base branch from master to release/443-release-candidate May 25, 2023 08:09
@maziyarpanahi maziyarpanahi merged commit 2b5c52d into JohnSnowLabs:release/443-release-candidate May 25, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation DON'T MERGE Do not merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DocumentAssembler on array<string>
3 participants