Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPARKNLP-846: BART: Added maxInputLength. #13863

Merged
merged 2 commits into from
Jul 1, 2023
Merged

SPARKNLP-846: BART: Added maxInputLength. #13863

merged 2 commits into from
Jul 1, 2023

Conversation

prabod
Copy link
Contributor

@prabod prabod commented Jun 22, 2023

Description

Added maxInputLength to BartTransformer. fixes #13829

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@prabod prabod added the bug-fix label Jun 22, 2023
@maziyarpanahi maziyarpanahi self-requested a review June 25, 2023 09:34
@maziyarpanahi maziyarpanahi self-assigned this Jun 25, 2023
@maziyarpanahi maziyarpanahi changed the base branch from master to release/500-release-candidate June 25, 2023 09:34
@maziyarpanahi maziyarpanahi merged commit 7645ad4 into release/500-release-candidate Jul 1, 2023
7 checks passed
@maziyarpanahi maziyarpanahi mentioned this pull request Jul 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maziyarpanahi maziyarpanahi maziyarpanahi approved these changes

Assignees

@maziyarpanahi maziyarpanahi

Labels
bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BART Summarization max tokens?
2 participants
@prabod @maziyarpanahi