Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARKNLP-869 Adding threshold to properties for python module #13890

Conversation

danilojsl
Copy link
Contributor

Description

This change adds threshold for Classifier DL components in Python module

Motivation and Context

Fix a bug when Python users try to use threshold parameter

How Has This Been Tested?

Screenshots (if appropriate):

  • Local Tests
  • Google Colab notebook

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danilojsl danilojsl added bug-fix DON'T MERGE Do not merge this PR labels Jul 11, 2023
@maziyarpanahi maziyarpanahi changed the base branch from master to release/501-release-candidate July 18, 2023 10:44
@maziyarpanahi maziyarpanahi merged commit 4620feb into release/501-release-candidate Jul 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix DON'T MERGE Do not merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants