Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BART Bug fix #13898 #13911

Merged
merged 1 commit into from
Aug 2, 2023
Merged

BART Bug fix #13898 #13911

merged 1 commit into from
Aug 2, 2023

Conversation

prabod
Copy link
Contributor

@prabod prabod commented Aug 1, 2023

BART low temperature value bug fix

Description

This PR fixes a bug that will occur when there are no non infinite logits satisfying the low temperature and top_k values.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@prabod prabod self-assigned this Aug 1, 2023
@maziyarpanahi maziyarpanahi added bug-fix DON'T MERGE Do not merge this PR labels Aug 2, 2023
@maziyarpanahi maziyarpanahi changed the base branch from master to release/502-release-candidate August 2, 2023 13:19
@maziyarpanahi maziyarpanahi merged commit 18cbb66 into release/502-release-candidate Aug 2, 2023
6 checks passed
@maziyarpanahi maziyarpanahi mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maziyarpanahi maziyarpanahi maziyarpanahi approved these changes

Assignees

@prabod prabod

Labels
bug-fix DON'T MERGE Do not merge this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prabod @maziyarpanahi