Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARKNLP-732 Unify all externally supported file systems and cloud access #13919

Conversation

danilojsl
Copy link
Contributor

Description

This change introduces a redesign of the integration architecture with S3 and GCP.
Additionally, it adds Azure support for:

Defining cache_pretrained directory
Training NER logs
Importing HF models in Spark NLP
Loading TF Graphs for NER-DL

Motivation and Context

To have universal methods so we can deal with storage cloud providers (S3, GCP, and Azure )from the same classes

How Has This Been Tested?

Screenshots (if appropriate):

  • Local tests
  • Databricks notebooks
  • Google Colab notebooks
  • GCP Dataproc Cluster

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danilojsl danilojsl added DON'T MERGE Do not merge this PR enhancement new-feature Introducing a new feature labels Aug 8, 2023
@maziyarpanahi maziyarpanahi changed the base branch from master to release/510-release-candidate August 24, 2023 07:48
@maziyarpanahi maziyarpanahi merged commit 09bae6c into release/510-release-candidate Aug 24, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DON'T MERGE Do not merge this PR enhancement new-feature Introducing a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants