[SPARKNLP-949] Adding changes for spark 3.5 compatibility #14105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maziyarpanahi
approved these changes
Dec 27, 2023
| @@ -22,9 +23,10 @@ object Dependencies { | |||
| val is_spark31: String = System.getProperty("is_spark31", "false") | |||
| val is_spark32: String = System.getProperty("is_spark32", "false") | |||
| val is_spark33: String = System.getProperty("is_spark33", "false") | |||
| val is_spark34: String = System.getProperty("is_spark34", "true") | |||
| val is_spark34: String = System.getProperty("is_spark34", "false") | |||
There was a problem hiding this comment.
@danilojsl let's keep Spark 3.4 default, changing this version here will result in saving and re-uploading all the pipelines
maziyarpanahi
changed the base branch from
master
to
release/521-release-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds the required modifications to make spark-nlp compatible with spark 3.5.x
Motivation and Context
Compatibility with latest spark versions
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: