Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to AhoCorasick implementation in order to pass Suffix Link tests #14189

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jfernandrezj
Copy link
Contributor

Description

Added a fix to correctly include a chunk annotation when jumping from a leaf node through a Suffix Link
Added a fix to correctly determine the span of a chunk annotation when jumping from a non-leaf node through a Suffix Link

Motivation and Context

#14187

How Has This Been Tested?

Added tests that should pass and did not pass before the fix
Java 11
Spark 3.4
Spark NLP 5.2.2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@maziyarpanahi maziyarpanahi added DON'T MERGE Do not merge this PR on-hold cannot be merged right away labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DON'T MERGE Do not merge this PR on-hold cannot be merged right away
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants