Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset Path in Ner Approach #39

Merged
merged 5 commits into from Oct 30, 2017
Merged

Dataset Path in Ner Approach #39

merged 5 commits into from Oct 30, 2017

Conversation

aleksei-ai
Copy link
Contributor

Added dataset path to CrfBasedNer

Description

Added option to train from dataset saved in file.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@saif-ellafi
Copy link
Contributor

Aleksei, this looks very good, just a few things and we can get going:

  1. Please rename CrfBasedNer to CrfBasedNerApproach to match other annotators name standard
  2. Please update AnnotatorBuilder.getCrfBasedNerModel with using datasetPath even with an invented source to make sure we are testing it, so it is used by CrfBasedNerPipelineSpec
  3. Optional but suggested, handle invalid path or read from jvm resources (perhaps use the ResourceHelper Resource class)

Thanks

@saif-ellafi
Copy link
Contributor

This is work in progress, not yet finished for review

2. Annotation result refactoring fixes
@aleksei-ai
Copy link
Contributor Author

I've renamed and added dataset to tests.
Got stuck a bit because Annotation Result refactoring left small problems and bugs in .ipynb code.

@saif-ellafi saif-ellafi merged commit 8d58161 into master Oct 30, 2017
@aleksei-ai aleksei-ai deleted the ner_dataset_path branch December 18, 2017 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants