Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder contains file/subfolder #64

Merged
merged 3 commits into from
Mar 12, 2019

Conversation

clayellis
Copy link
Contributor

This PR adds two methods to Folder:

  1. contains(_ file: File)
  2. contains(_ subfolder: Folder)

Resolves #60

@clayellis clayellis mentioned this pull request May 24, 2018
Copy link
Owner

@JohnSundell JohnSundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @clayellis! Put a few comments inline, let me know what you think 🙂

Sources/Files.swift Outdated Show resolved Hide resolved
Sources/Files.swift Outdated Show resolved Hide resolved
Tests/FilesTests/FilesTests.swift Outdated Show resolved Hide resolved
Copy link
Owner

@JohnSundell JohnSundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@JohnSundell JohnSundell merged commit 073242f into JohnSundell:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants