Add twitter:site meta tag nodes #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This initialiser will create a link with only an id tag to be used for intra-page linking
Add Time Component
JohnSundell
requested changes
Mar 31, 2023
There was a problem hiding this comment.
The commits from #86 also seem to be included in this PR. Could you please separate them, so that this PR only contains the commits relevant to the Twitter attribute that this PR aims to add, and then I'll review it?
JohnSundell
added
the
awaiting update
I think it will be easier to open a new PR with the changes, I'll do that now and close this one |
|
Added a new PR #92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This change is quite simple but something that is quite nice to have.
The tag twitter:site is used to identify the site by it's Twitter handle (for example the @ SwiftBySundell twitter account) when shown in a card. See the (documentation)[https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/markup]
I added a new node
.twitterUsername(_)to set the Twitter username to be associated with the page.