Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License put in by default #19

Closed
codeOfRobin opened this issue Nov 23, 2016 · 5 comments
Closed

License put in by default #19

codeOfRobin opened this issue Nov 23, 2016 · 5 comments

Comments

@codeOfRobin
Copy link
Contributor

It looks like the generated files have the MIT License put in by default at the top of all files. Though it doesn't really make a difference to my org (we're open sourcing most of our stuff), people might have a problem with it.
screen shot 2016-11-23 at 4 42 27 pm

@JohnSundell
Copy link
Owner

Yeah, we should probably ask when SwiftPlate is run what license that the user wants to use, and add that both to the LICENSE file and as a header to all source files.

@kiliankoe
Copy link
Contributor

Do source files really need a license header? Isn't a LICENSE file enough? Just feels so unnecessary 😕

@codeOfRobin
Copy link
Contributor Author

I kinda agree with @kiliankoe . Can't we just us the XCode default of

//
//  <File Name>
//  <org name>
//
//  Created by <Dev name> on 22/08/16.
//  Copyright © 2016 <Org Name>. All rights reserved.
//

@JohnSundell
Copy link
Owner

Yeah, the Xcode defaults should be enough actually 👍 (if people want to add a license header to the source + test file they can easily do so after SwiftPlate has generated them anyway)

JohnSundell added a commit that referenced this issue Mar 6, 2017
Replaced MIT license header with Xcode header #19
@JohnSundell
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants