Total line length not taken into account in for loops

[evaera]

I have a for loop with a long initial line. StyLua formats it like this:

local function system(world)
	for id, model, lasering, transform in world:query(Components.Model, Components.Lasering, Components.Transform, Components.Mothership) do
	end
end

If I make the function call longer, StyLua formats it more correctly:

local function system(world)
	for id, model, lasering, transform in world:query(
		Components.Model,
		Components.Lasering,
		Components.Transform,
		Components.Mothership,
		Components.Mothership
	) do
	end
end

But if I add more variables to the loop, it does not do anything:

local function system(world)
	for id, model, lasering, transform, id, model, lasering, transform, id, model, lasering, transform, id, model, lasering, transform in world:query(Components.Model, Components.Lasering, Components.Transform, Components.Mothership) do
	end
end

Ideally, the formatter should probably produce something close to this:

local function system(world)
	for id, model, lasering, transform,
		id, model, lasering, transform, 
		id, model, lasering, transform, 
		id, model, lasering, transform 
	in
		world:query(
			Components.Model,
			Components.Lasering,
			Components.Transform,
			Components.Mothership,
			Components.Model,
			Components.Lasering,
			Components.Transform,
			Components.Mothership
		)
	do
	end
end

[JohnnyMorganz]

The initial input is over width, so we seem to be incorrectly calculating the current amount of line width taken up here. Prettier example for reference

In your ideal case, I think the best we could do is probably split each individual variable on its own line. Splitting every X (in this case 4) variables seems very arbitrary (in this case it works since its 4 variables repeated), so I'm not sure if its the right way to go. Of course, the downside is that it takes up a lot of vertical space sticking each variable on a new line, but this is the format prettier also uses.

[evaera]

The initial input is over width, so we seem to be incorrectly calculating the current amount of line width taken up here. Prettier example for reference

In your ideal case, I think the best we could do is probably split each individual variable on its own line. Splitting every X (in this case 4) variables seems very arbitrary (in this case it works since its 4 variables repeated), so I'm not sure if its the right way to go. Of course, the downside is that it takes up a lot of vertical space sticking each variable on a new line, but this is the format prettier also uses.

👍 Whatever you think is best