Multiline formatting of generic for syntax #337
Conversation
| Components.Transform, | ||
| Components.Mothership, | ||
| Components.Mothership | ||
| ) do |
There was a problem hiding this comment.
hm. Is there a reason we don't align the do with the end, like we do for similar scope closure pairs like: function() and end, if and else?
There was a problem hiding this comment.
In this case, I followed how prettier did it
It seems that in a for loop, the body opening bracket is aligned with the closing parentheses, but in an if-statement they don't do this...
I think I agree, its probably better to just keep it consistent with how we do if ... then expanded multiline. Also makes it easier to handle comments
| end | ||
|
|
||
| local function system(world) | ||
| for id, |
There was a problem hiding this comment.
why isn't id indented on the next line like the rest of the arguments? again, I'm thinking of consistency with the if and else cases
There was a problem hiding this comment.
I don't think there was a particular reason for this, just how I did it (its interesting how the the id in the first line aligns nicely with the other variables too, thats wasn't intentional).
Again, I agree its better to be consistent here so I'll change it
Aligned more with `if .... then` syntax etc.
|
@matthargett, wanted your opinion on the changes (I can't seem to re-request your review) |
|
I didn’t test locally, but reviewing the tests it looks good to me. |
… for-loop-multiline
Closes #322