New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary parentheses around typecasts #383

Closed

matthargett opened this issue Feb 19, 2022 · 1 comment · Fixed by #419

Labels

matthargett commented Feb 19, 2022

                                    local firstPendingUpdate = ((lastPendingUpdate.next :: any) :: Update<State>)

what happens in-context:

JohnnyMorganz added the enhancement label

JohnnyMorganz changed the title ~~should remove superfluous parenthesis~~ Remove unnecessary parentheses around typecasts

Owner

JohnnyMorganz commented Mar 25, 2022

Cases we need to ensure we keep parentheses:

local x = #(expr :: Array<any>)
local y = -(expr :: number)
local z = (expr :: any) :: string

JohnnyMorganz mentioned this issue

Remove excess parentheses around type assertions #419

Merged

JohnnyMorganz closed this as completed in #419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment