Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excess parentheses around type assertions #419

Merged
merged 4 commits into from
Mar 25, 2022

Conversation

JohnnyMorganz
Copy link
Owner

Closes #383

- Keep the in double assertion cases (expr :: any) :: number
- Keep them in unary cases: #(expr :: Array<string>) or -(expr :: number)
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #419 (1a5ff8d) into master (6e34c98) will decrease coverage by 0.00%.
The diff coverage is 96.96%.

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
- Coverage   96.43%   96.42%   -0.01%     
==========================================
  Files          14       14              
  Lines        5099     5116      +17     
==========================================
+ Hits         4917     4933      +16     
- Misses        182      183       +1     
Impacted Files Coverage Δ
src/formatters/expression.rs 96.87% <96.96%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e34c98...1a5ff8d. Read the comment docs.

@JohnnyMorganz JohnnyMorganz merged commit e2e9a97 into master Mar 25, 2022
@JohnnyMorganz JohnnyMorganz deleted the excess-assertion-parens branch March 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary parentheses around typecasts
1 participant