Add a system hook for people who don't have the rust toolchain #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add back the option for a
system
pre-commit hook. Otherwise every update will require cargo and the rust tool chain, which some Lua developers may not have and may prefer to install their own binary.One downside to
system
hooks is that the version tag is really irrelevant as it won't update the checker.Another option would be to do something like this: https://github.com/shellcheck-py/shellcheck-py and provide a wrapper. This example uses Python to manage the download and installation. Since this person has put this in it's own repo, they are hard coding the version and sha's.
I'm tempted to write a Python package that can accept a git repo as an argument and then it will download the release using repo metadata (reading
Cargo.toml
) and then execute that binary. This would be helpful, not just for StyLua, but any statically compiled checkers that have dependencies.