Luau: Implement proper IfExpression formatting #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We format fully on a single line, then determine if it fits nicely If not, we then expand it out
i.e. `then <expr>` or `else <expr>`
|
I think the implementation for this is complete. Tested it on the codebases I have, they don't have a lot of if-expression syntax but for everything they do have, it seems to be formatting well. I'll wait a while to see if others have anything they would like to bring up before merging this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We format fully on a single line, then determine if it fits nicely
If not, we then expand it out
Closes #289 and Fixes #321
Available to test via