Fix mistransformation of type unions with comments #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthargett
reviewed
Feb 1, 2022
| export type ReactNode = | ||
| React_Element<any> | ||
| | ReactPortal | ||
| -- | ReactText |
There was a problem hiding this comment.
Why does the ReactText comment get indented when the other comment don’t?
There was a problem hiding this comment.
ReactText is an in-line comment in the type union
The other comments aren't part of the type union, they are just statement level comments, so they aren't indented.
If you moved the other two comments before the last union type, it would be indented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #351,
Also fixes loss of comments when hanging a type union