Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include types in generic for shape calculation #361

Merged
merged 3 commits into from Feb 6, 2022

Conversation

JohnnyMorganz
Copy link
Owner

Fixes #360

Copy link

@matthargett matthargett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be another test that does the same pattern for

  1. function declaration argument list: local function World.query.transform(AngualarControls: any, CharacterModel: any, _id: number, transform: Components.Transform, angularControls: Components.AngularControls, characterModel: Components.CharacterModel) end
  2. function assignment argument list: local World.query.transform = function(AngualarControls: any, CharacterModel: any, _id: number, transform: Components.Transform, angularControls: Components.AngularControls, characterModel: Components.CharacterModel) end
  3. function type assignment: local type WorldQueryTransform = (AngualarControls: any, CharacterModel: any, _id: number, transform: Components_Transform, angularControls: Components_AngularControls, characterModel: Components_CharacterModel) -> ()
  4. table type assignment: local type WorldQueryTransform = { AngualarControls: any, CharacterModel: any, _id: number, transform: Components_Transform, angularControls: Components_AngularControls, characterModel: Components_CharacterModel }

@JohnnyMorganz JohnnyMorganz merged commit 3be10b4 into master Feb 6, 2022
@JohnnyMorganz JohnnyMorganz deleted the generic-for-types-multiline branch February 6, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variables' types not taken into account in for loop
2 participants