Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hang type union declarations if multiline comment is seen #402

Merged
merged 4 commits into from Mar 17, 2022

Conversation

JohnnyMorganz
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #402 (e6502b4) into master (28c9b9c) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head e6502b4 differs from pull request most recent head 86d7fbb. Consider uploading reports for the commit 86d7fbb to get more accurate results

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
- Coverage   96.40%   96.25%   -0.15%     
==========================================
  Files          14       14              
  Lines        5057     5047      -10     
==========================================
- Hits         4875     4858      -17     
- Misses        182      189       +7     
Impacted Files Coverage Δ
src/formatters/functions.rs 97.59% <0.00%> (-1.02%) ⬇️
src/formatters/trivia_util.rs 94.67% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c9b9c...86d7fbb. Read the comment docs.

@matthargett
Copy link

Might be worth capturing the intersection cases as well

@JohnnyMorganz JohnnyMorganz merged commit c68aa9c into master Mar 17, 2022
@JohnnyMorganz JohnnyMorganz deleted the luau/hang-multiline-comments branch March 17, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants