Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break down function argument code #408

Merged
merged 2 commits into from Mar 16, 2022
Merged

Break down function argument code #408

merged 2 commits into from Mar 16, 2022

Conversation

JohnnyMorganz
Copy link
Owner

Cleaning up the tech debt, this code was very difficult to read.
Its still not great, but its an improvement

@JohnnyMorganz
Copy link
Owner Author

Why are actions not running 🤔

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #408 (67f2a5f) into master (32208aa) will increase coverage by 0.14%.
The diff coverage is 98.70%.

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
+ Coverage   96.25%   96.40%   +0.14%     
==========================================
  Files          14       14              
  Lines        5047     5057      +10     
==========================================
+ Hits         4858     4875      +17     
+ Misses        189      182       -7     
Impacted Files Coverage Δ
src/formatters/functions.rs 98.60% <98.70%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32208aa...67f2a5f. Read the comment docs.

@JohnnyMorganz JohnnyMorganz merged commit 9833ac1 into master Mar 16, 2022
@JohnnyMorganz JohnnyMorganz deleted the cleanup branch March 16, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants