Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments ordering when semicolon removed after stmt #424

Merged
merged 5 commits into from Mar 28, 2022

Conversation

JohnnyMorganz
Copy link
Owner

Fixes #423

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #424 (bff8795) into master (84b68b8) will decrease coverage by 0.07%.
The diff coverage is 94.39%.

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
- Coverage   96.42%   96.34%   -0.08%     
==========================================
  Files          14       14              
  Lines        5121     5174      +53     
==========================================
+ Hits         4938     4985      +47     
- Misses        183      189       +6     
Impacted Files Coverage Δ
src/formatters/trivia.rs 86.36% <89.65%> (+0.60%) ⬆️
src/formatters/block.rs 97.75% <100.00%> (+0.12%) ⬆️
src/formatters/trivia_util.rs 94.43% <100.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b68b8...bff8795. Read the comment docs.

@JohnnyMorganz
Copy link
Owner Author

Uncovered lines are impossible to cover, so it is a non-issue

@JohnnyMorganz JohnnyMorganz merged commit 80483fe into master Mar 28, 2022
@JohnnyMorganz JohnnyMorganz deleted the semicolon-comments-order branch March 28, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments order is changed for statements with multiple comments and a semicolon at the end
1 participant