Build release on Ubuntu 18 #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
==========================================
+ Coverage 96.42% 96.44% +0.01%
==========================================
Files 14 14
Lines 5228 5257 +29
==========================================
+ Hits 5041 5070 +29
Misses 187 187
Continue to review full report at Codecov.
|
|
will these binaries be compatible with new Ubuntu LTS when it's released? |
|
My understanding is that glibc is generally backwards compatible, but never forwards compatible. |
|
Thanks! |
JohnnyMorganz
added a commit
to JohnnyMorganz/rojo
that referenced
this pull request
Jun 26, 2022
ubuntu-latest uses Ubuntu 20.04, this causes issues with glibc as older versions of ubuntu/other distros use an older version. This is fixed by building the release binary on `ubuntu-18.04`, which uses a version of glibc more widely available. Ref: JohnnyMorganz/StyLua#444 JohnnyMorganz/StyLua#445
LPGhatguy
pushed a commit
to rojo-rbx/rojo
that referenced
this pull request
Jun 26, 2022
ubuntu-latest uses Ubuntu 20.04, this causes issues with glibc as older versions of ubuntu/other distros use an older version. This is fixed by building the release binary on `ubuntu-18.04`, which uses a version of glibc more widely available. Ref: JohnnyMorganz/StyLua#444 JohnnyMorganz/StyLua#445
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
ubuntu-latest uses Ubuntu 20.04, this causes issues with glibc as older versions of ubuntu/other distros use an older version. This is fixed by building the release binary on `ubuntu-18.04`, which uses a version of glibc more widely available. Ref: JohnnyMorganz/StyLua#444 JohnnyMorganz/StyLua#445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed all runners to use
ubuntu-18.04.I closed #444 in favor of building on ubuntu 18 and older version of glibc.