Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix severe perf regression of complex nested function calls #478

Merged
merged 4 commits into from Jun 26, 2022

Conversation

JohnnyMorganz
Copy link
Owner

Fixes #477

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #478 (4dfcd0e) into master (97c4b53) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #478   +/-   ##
=======================================
  Coverage   97.48%   97.49%           
=======================================
  Files          14       14           
  Lines        4978     4994   +16     
=======================================
+ Hits         4853     4869   +16     
  Misses        125      125           
Impacted Files Coverage Δ
src/formatters/functions.rs 98.61% <100.00%> (+0.01%) ⬆️
src/shape.rs 98.41% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97c4b53...4dfcd0e. Read the comment docs.

@JohnnyMorganz
Copy link
Owner Author

Performance is still not 100% where we want it to be, but this is a big improvement

@JohnnyMorganz JohnnyMorganz merged commit ec676a7 into master Jun 26, 2022
@JohnnyMorganz JohnnyMorganz deleted the perf-regression branch June 26, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Severe performance regression with complex nested function calls
1 participant