Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aarch64 target #529

Merged
merged 3 commits into from Aug 8, 2022
Merged

Fix aarch64 target #529

merged 3 commits into from Aug 8, 2022

Conversation

mvllow
Copy link
Contributor

@mvllow mvllow commented Aug 8, 2022

According to rust-lang/rust#73908 this should be supported. Not sure of an easy way to test the workflow but let me know if there's anything else that's needed :)

Closes #528

According to rust-lang/rust#73908 this should be supported.

Closes #528
Copy link
Owner

@JohnnyMorganz JohnnyMorganz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding a quick sentence under "Fixed" in the CHANGELOG?

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #529 (3c540f2) into master (86fae14) will not change coverage.
The diff coverage is n/a.

❗ Current head 3c540f2 differs from pull request most recent head d7212de. Consider uploading reports for the commit d7212de to get more accurate results

@@           Coverage Diff           @@
##           master     #529   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files          14       14           
  Lines        5390     5390           
=======================================
  Hits         5264     5264           
  Misses        126      126           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mvllow
Copy link
Contributor Author

mvllow commented Aug 8, 2022

Added to the unreleased section as I assume this will require a version bump but happy to change if needed!

Copy link
Owner

@JohnnyMorganz JohnnyMorganz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

CHANGELOG.md Outdated Show resolved Hide resolved
@JohnnyMorganz JohnnyMorganz merged commit f4706e8 into JohnnyMorganz:master Aug 8, 2022
@mvllow mvllow deleted the patch-1 branch August 8, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad CPU type in executable running macOS on an m1
2 participants