Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alternative way to compute large scale diffs #564

Merged
merged 5 commits into from
Sep 3, 2022

Conversation

JohnnyMorganz
Copy link
Owner

@JohnnyMorganz JohnnyMorganz commented Sep 3, 2022

Currently, we compute large scale diffs using the following steps:

  • Clone repo
  • Run stylua main on repo
  • Commit main changes
  • Run stylua PR on repo again (but this is based of already-formatted code from main)
  • Compute diff

Since we run stylua PR on the already-formatted code, the diff computed isn't necessarily correct.

This adds in a new method:

  • Clone repo
  • Run stylua main on repo
  • Commit main changes
  • Restore repo to original
  • Run stylua PR on repo again (based on original)
  • Compute diff between main changes and current

This provides more accurate diffs.

@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #564 (cbb7923) into main (fa59c03) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #564   +/-   ##
=======================================
  Coverage   97.80%   97.80%           
=======================================
  Files          14       14           
  Lines        5431     5431           
=======================================
  Hits         5312     5312           
  Misses        119      119           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2022

Repo Comparison Test

diff --git ORI/lit/commands/serve.lua ALT/lit/commands/serve.lua
index 38e6078..183600b 100644
--- ORI/lit/commands/serve.lua
+++ ALT/lit/commands/serve.lua
@@ -38,10 +38,8 @@ return function()
 	end)
 
 	app.use(require("weblit-auto-headers"))
-.route({ method = "GET", path = "/snapshots" }, require("snapshots")).route(
-		{ method = "GET", path = "/stats" },
-		require("stats")
-	)
+		.route({ method = "GET", path = "/snapshots" }, require("snapshots"))
+		.route({ method = "GET", path = "/stats" }, require("stats"))
 
 	-- Handle websocket clients
 	app.websocket({

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2022

Repo Comparison Test

diff --git ORI/lit/commands/serve.lua ALT/lit/commands/serve.lua
index 38e6078..183600b 100644
--- ORI/lit/commands/serve.lua
+++ ALT/lit/commands/serve.lua
@@ -38,10 +38,8 @@ return function()
 	end)
 
 	app.use(require("weblit-auto-headers"))
-.route({ method = "GET", path = "/snapshots" }, require("snapshots")).route(
-		{ method = "GET", path = "/stats" },
-		require("stats")
-	)
+		.route({ method = "GET", path = "/snapshots" }, require("snapshots"))
+		.route({ method = "GET", path = "/stats" }, require("stats"))
 
 	-- Handle websocket clients
 	app.websocket({

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2022

Repo Comparison Test

diff --git ORI/lit/commands/serve.lua ALT/lit/commands/serve.lua
index 38e6078..183600b 100644
--- ORI/lit/commands/serve.lua
+++ ALT/lit/commands/serve.lua
@@ -38,10 +38,8 @@ return function()
 	end)
 
 	app.use(require("weblit-auto-headers"))
-.route({ method = "GET", path = "/snapshots" }, require("snapshots")).route(
-		{ method = "GET", path = "/stats" },
-		require("stats")
-	)
+		.route({ method = "GET", path = "/snapshots" }, require("snapshots"))
+		.route({ method = "GET", path = "/stats" }, require("stats"))
 
 	-- Handle websocket clients
 	app.websocket({

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2022

Repo Comparison Test

No diff produced

@JohnnyMorganz JohnnyMorganz merged commit e4740f9 into main Sep 3, 2022
@JohnnyMorganz JohnnyMorganz deleted the improve-large-scale-test branch September 3, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant