Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't collapse when comment present in typeinfo tuple #612

Merged
merged 4 commits into from Oct 27, 2022

Conversation

JohnnyMorganz
Copy link
Owner

We were not checking for comments on the typeinfo in the last Pair::End in the tuple

Fixes #608

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 97.65% // Head: 97.65% // No change to project coverage 👍

Coverage data is based on head (81bc5b7) compared to base (b8c32f7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #612   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files          14       14           
  Lines        5577     5577           
=======================================
  Hits         5446     5446           
  Misses        131      131           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Repo Comparison Test

No diff produced

@JohnnyMorganz JohnnyMorganz merged commit bee202b into main Oct 27, 2022
@JohnnyMorganz JohnnyMorganz deleted the type-parens-comments branch October 27, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax error when formatting luau return type and trailing comment
1 participant