Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bind repoWatch to RepositoryFilesWatcher object #1591

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

FractalBoy
Copy link
Contributor

Currently, when files are changed, there is an exception that breaks the SVN extension.

2022-12-20 17:21:44.105 [error] TypeError: Cannot read properties of undefined (reading 'fire')
	at /home/mreisner/.vscode-server/extensions/johnstoncode.svn-scm-2.15.5/out/extension.js:2:278235

This pull request binds the call to this.repoWatch to the RepositoryFilesWatcher object so that this exception isn't triggered.

@FractalBoy FractalBoy changed the title Bind repoWatch to RepositoryFilesWatcher object fix: bind repoWatch to RepositoryFilesWatcher object Dec 20, 2022
@JohnstonCode JohnstonCode self-requested a review December 21, 2022 12:45
@JohnstonCode JohnstonCode merged commit 32be3f9 into JohnstonCode:master Dec 21, 2022
@JohnstonCode
Copy link
Owner

Thanks for the PR!

JohnstonCode added a commit that referenced this pull request Dec 21, 2022
## [2.15.6](v2.15.5...v2.15.6) (2022-12-21)

### Bug Fixes

* bind repoWatch to RepositoryFilesWatcher object ([#1591](#1591)) ([32be3f9](32be3f9))
JohnstonCode added a commit that referenced this pull request Dec 21, 2022
## [2.15.6](v2.15.5...v2.15.6) (2022-12-21)

### Bug Fixes

* bind repoWatch to RepositoryFilesWatcher object ([#1591](#1591)) ([32be3f9](32be3f9))
JohnstonCode added a commit that referenced this pull request Dec 21, 2022
## [2.15.6](v2.15.5...v2.15.6) (2022-12-21)

### Bug Fixes

* bind repoWatch to RepositoryFilesWatcher object ([#1591](#1591)) ([32be3f9](32be3f9))
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 2.15.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@FractalBoy
Copy link
Contributor Author

Hey @JohnstonCode - I don't see the new version on Visual Studio Marketplace. Does it take a while to show up?

@JohnstonCode
Copy link
Owner

I'll have a look not usually its a couple of minutes

@JohnstonCode
Copy link
Owner

It seems Microsoft change the rules around allowed badges in the readme. I have fixed this and 2.15.7 is now available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants