Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not works properly when source file contains "@" #223

Closed
dimazev opened this issue Mar 19, 2018 · 5 comments
Closed

Does not works properly when source file contains "@" #223

dimazev opened this issue Mar 19, 2018 · 5 comments
Assignees
@edgardmessias
Labels
bug released

Comments

@dimazev
Copy link

dimazev commented Mar 19, 2018

  • VSCode Version: latest
  • OS Version: Mac
  • Extension Version: latest
  • System Language: TS
  • SVN Version: 1.9

Issue

Steps to Reproduce

create file wich contains "@" for example file test@any.txt

SVN Output

svn: E205000: Try 'svn help cat' for more information
svn: E205000: Syntax error parsing peg revision 'any.txt'

Screenshots
@edgardmessias edgardmessias self-assigned this Mar 20, 2018
@edgardmessias
Copy link
Contributor

About: http://svnbook.red-bean.com/en/1.8/svn.advanced.pegrevs.html

JohnstonCode added a commit that referenced this issue Mar 20, 2018
@JohnstonCode
Merge pull request #225 from edgardmessias/filename_with_peg_revision
ebd7714 
Fixed file name with "@" (Close #223)
@guusw
Copy link

guusw commented Jun 3, 2019

This still happens in version 1.50.1 of the extension (svn version 1.11.0)

@edgardmessias
Copy link
Contributor

@guusw can you describe the problem?

@edgardmessias
Copy link
Contributor

edgardmessias commented Jun 3, 2019 •
edited
Loading

I found the problem. When show diff with BASE, incorrect URL are generated

@edgardmessias edgardmessias reopened this Jun 3, 2019
edgardmessias added a commit to edgardmessias/svn-scm that referenced this issue Jun 3, 2019
@edgardmessias
fix: Fixed diff for files with "@" (close JohnstonCode#223)
18bee0a
JohnstonCode added a commit that referenced this issue Jun 3, 2019
@JohnstonCode
chore(release): 1.50.2 [skip ci]
5577bc2 
## [1.50.2](v1.50.1...v1.50.2) (2019-06-03)

### Bug Fixes

* Fixed diff for files with "@" (close [#223](#223)) ([#595](#595)) ([ee41f49](ee41f49))
@JohnstonCode
Copy link
Owner

🎉 This issue has been resolved in version 1.50.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edgardmessias edgardmessias

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@edgardmessias @JohnstonCode @guusw @dimazev