Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: SVN status in file explorer #34

Closed
agrlh opened this issue Nov 19, 2017 · 25 comments
Closed

Feature: SVN status in file explorer #34

agrlh opened this issue Nov 19, 2017 · 25 comments

Comments

@agrlh
Copy link

agrlh commented Nov 19, 2017

I'd love to see the SVN status indicated with colors/icons in the file explorer similar to the GIT integration in 1.18:

GIT file explorer decorations
Image stolen from microsoft/vscode#178

Maybe it's possible to reuse the git code from the official extension: https://github.com/Microsoft/vscode/tree/master/extensions/git ?

I'd be happy to help out, if you can provide me some pointers on where to start (I'm new to VSCode)

@JohnstonCode
Copy link
Owner

Hi @arppl

This is something that I have wanted to implement. So far I have not found any docs on how to implement this.

I have also looked through the git extension source and can't see anything that stands out.

If you can find any references please let me know.

@magic-k
Copy link

magic-k commented Nov 21, 2017

It seems to be implemented only inside the git extension. From the Changelogs of 1.18:

There is also a proposed API to allow extension authors to add color decorations to arbitrary resources. We haven't finalized on anything yet but are eager to learn how you would use decorations.

Maybe contact microsoft directly?

@edgardmessias
Copy link
Contributor

@JohnstonCode
Copy link
Owner

Ta, I will have a look.

@edgardmessias
Copy link
Contributor

See the link: https://code.visualstudio.com/updates/v1_18#_git-status-in-file-explorer

There is also a proposed API to allow extension authors to add color decorations to arbitrary resources.

@JohnstonCode JohnstonCode self-assigned this Nov 27, 2017
@s-martin
Copy link

s-martin commented Dec 4, 2017

In addition, I'd like to see the revision of a file at least in the SCM view

@edgardmessias
Copy link
Contributor

@JohnstonCode, you can test my branch?
https://github.com/edgardmessias/svn-scm/tree/status_file_explorer

How to enable:

  • Open the file: <vscode path>\resources\app\product.json
  • Find extensionAllowedProposedApi
  • Append "johnstoncode.svn-scm" in the array

Example:
From

{
	"extensionAllowedProposedApi": [
		"ms-vsliveshare.vsliveshare"
	]
}

To:

{
	"extensionAllowedProposedApi": [
		"ms-vsliveshare.vsliveshare", "johnstoncode.svn-scm"
	]
}

This trick is to avoid putting "enableProposedApi": true in package.json, allowing to publish in marketplace

@JohnstonCode
Copy link
Owner

@edgardmessias

Unversioned doesn't seem to work in the file explorer but does in the SCM view.

@edgardmessias
Copy link
Contributor

@JohnstonCode, fixed

@JohnstonCode
Copy link
Owner

Yeah looks good and works

@edgardmessias
Copy link
Contributor

More suggestion?
Should we release a version?

@JohnstonCode
Copy link
Owner

If you create a PR I will merge it and release it. Get some real-world feedback that way

@edgardmessias
Copy link
Contributor

Okay, I'll do some documentation first.

JohnstonCode added a commit that referenced this issue Feb 2, 2018
Added support to SVN status in file explorer (Close #34)
@derwaldgeist
Copy link

Has this been resolved? I am using svn in combination with VS Code 1.21.1 and cannot get the color-coding work in Windows or macOS.

@JohnstonCode
Copy link
Owner

This uses the ProposedApi once VS code releases it fully it should work.

@edgardmessias
Copy link
Contributor

@derwaldgeist, see this SVN Status in File Explorer

@derwaldgeist
Copy link

@edgardmessias Oh, cool, thanks. A typical variant of RTFM, I guess :-)

@teejay-87
Copy link

It only works if we open a folder which is a SVN repository (or its subfolder).
If I open a superfolder it does not work.

@Zastai
Copy link

Zastai commented Jun 27, 2019

It works only partially for me, having opened an svn-controlled folder also containing two svn externals.
Added files in the externals have an A and are colorized (green); their parent directories are also green.

However, modified files, while flagged with an M, are only briefly colorized orange, before being overwritten by a darkish grey color.

@edgardmessias
Copy link
Contributor

@Zastai, please, open a new issue

@Remzi1993
Copy link

It would be nice to put this also in the documentation, where to find product.json:
/usr/share/code/resources/app/product.json

I was looking for a long time. I think this is the default location.

@jflambert
Copy link

Thank you @Remzi1993 !!! Fully agree with your suggestion

@allanforms
Copy link

allanforms commented Apr 27, 2022

Hey guys, I'm trying to get this feature to work, but I had not succeed.
Now the product.json file has this entry

{
    "extensionEnabledApiProposals": {
        "ms-vsliveshare.vsliveshare": ["contribMenuBarHome", "diffCommand", "documentFiltersExclusive", "fileSearchProvider", "findTextInFiles", "notebookCellExecutionState", "notebookContentProvider", "notebookDocumentEvents", "notebookEditor", "notebookEditorEdit", "notebookLiveShare", "terminalDimensions", "terminalDataWriteEvent", "textDocumentNotebook", "textSearchProvider"]
    }
}

I tried to add

        "johnstoncode.svn-scm": [],

next to the "ms-vsliveshare.vsliveshare" entry but didn't notice any difference in file explorer or source control panels.

Any help is appreciated 😀

@edgardmessias
Copy link
Contributor

@allanforever , this option was removed a long time a go:
7fb3966

This option only exists for versions <2

@allanforms
Copy link

@edgardmessias : is there any other way to (highlight/mark down/put emblem/check) changed files in the Explorer panel?
I can see the list of changed files in Source Control panel, but I would love to see something (even an *) beside the filename in the Explorer panel.
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests