fix: Fixed compatibility with SlikSVN #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
==========================================
+ Coverage 61.94% 61.95% +0.01%
==========================================
Files 170 170
Lines 7182 7184 +2
Branches 1359 1359
==========================================
+ Hits 4449 4451 +2
Misses 2729 2729
Partials 4 4
Continue to review full report at Codecov.
|
| @@ -112,9 +112,11 @@ export class SvnFinder { | |||
|
|
|||
| public checkSvnVersion(svn: ISvn): Promise<ISvn> { | |||
| return new Promise<ISvn>((c, e) => { | |||
| if (!semver.valid(svn.version)) { | |||
| // fix compatibility with SlickSVN (like 1.6.17-SlikSvn-tag-1.6.17@1130898-X64) | |||
| const version = svn.version.replace(/^(\d+\.\d+\.\d+).*/, "$1"); | |||
There was a problem hiding this comment.
whats the .* needed for? ^(\d+\.\d+\.\d+) gets the version alone
There was a problem hiding this comment.
Fast version instead of match or exec
|
I use replace for single code: ...
let version = svn.version;
const match = /^(\d+\.\d+\.\d+)/.exec(svn.version);
if (match && match[0]) {
version = match[0]
}
... |
JohnstonCode
approved these changes
Oct 26, 2018
JohnstonCode
added a commit
that referenced
this pull request
Oct 26, 2018
## [1.44.4](v1.44.3...v1.44.4) (2018-10-26) ### Bug Fixes * Fixed compatibility with SlikSVN ([#397](#397)) ([21b4f6d](21b4f6d))
|
🎉 This PR is included in version 1.44.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.