Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix ignore SCM context menu #425

Merged
merged 2 commits into from
Nov 28, 2018
Merged

fix: Fix ignore SCM context menu #425

merged 2 commits into from
Nov 28, 2018

Conversation

JohnstonCode
Copy link
Owner

fixes #421

@edgardmessias
Copy link
Contributor

Maybe need check the resourceStates[1]

@JohnstonCode
Copy link
Owner Author

JohnstonCode commented Nov 28, 2018 •
edited
Loading

You mean like `!(resourceStates[0] instanceof Repository && resourceStates[1] instanceof Resource)?

@edgardmessias
Copy link
Contributor

I need debug locally, I think the resourceStates[1] is a array of Resource, and if true, need return it.

@JohnstonCode
Copy link
Owner Author

Never mind me being stupid

@JohnstonCode
Copy link
Owner Author

So the right click context seems to return the repository then all the selected resourceStates not in an array just additional arguments

@JohnstonCode
Copy link
Owner Author

Cant remember if this has always been the case

@edgardmessias
Copy link
Contributor

Only need remove the { repository: true } in addToIgnoreSCM.ts to fix #421

svn-scm/src/commands/addToIgnoreSCM.ts

Line 6 in 62def1c

super("svn.addToIgnoreSCM", { repository: true });

@edgardmessias
Copy link
Contributor

On my debug: removing the { repository: true } in addToIgnoreSCM.ts working fine, because the addToIgnore run by repository and the resourceStates only has resourceStates

@JohnstonCode
Copy link
Owner Author

completely missed that, I'm too tired

@JohnstonCode JohnstonCode merged commit 8f55f24 into master Nov 28, 2018
@JohnstonCode JohnstonCode deleted the fix-right-click-ignore branch November 28, 2018 18:28
JohnstonCode added a commit that referenced this pull request Nov 28, 2018
@JohnstonCode
chore(release): 1.46.3 [skip ci]
5f286d4 
## [1.46.3](v1.46.2...v1.46.3) (2018-11-28)

### Bug Fixes

* Fix ignore SCM context menu ([#425](#425)) ([8f55f24](8f55f24))
@JohnstonCode
Copy link
Owner Author

🎉 This PR is included in version 1.46.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@edgardmessias edgardmessias mentioned this pull request Mar 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgardmessias edgardmessias edgardmessias approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Right click ignore try to add ignore the opened file not a right clicked file
2 participants
@JohnstonCode @edgardmessias