Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace File deletion prompts for SVN removal breaking normal vscode UI flow #487

Closed
Sleaker opened this issue Mar 1, 2019 · 3 comments · Fixed by #498
Closed

workspace File deletion prompts for SVN removal breaking normal vscode UI flow #487

Sleaker opened this issue Mar 1, 2019 · 3 comments · Fixed by #498

Comments

@Sleaker
Copy link

Sleaker commented Mar 1, 2019

  • VSCode Version: 1.13.1
  • OS Version: Windows 10
  • Extension Version: 1.47.1
  • System Language: English
  • SVN Version: 1.11.0 (Tortoise)

Issue

workspace file deletions break process flow and pops a dialog asking the user if they want to remove the file from SVN.

Steps to Reproduce

  1. Remove a file from the vscode workspace that's checked into the SVN repository
  2. Press an interactive vscode command like ctl+p
  3. attempt to type in a file or action to perform
  4. SVN dialog pops up soon after breaking the flow

Alternative Steps

  1. Remove a file from the vscode workspace that's checked into the SVN repository
  2. Click and Hold on the workspace scrollbar.
  3. SVN plugin detects a workspace change and pops the SVN deletion prompt
  4. Click to delete the file.
  5. the scrollbar will still be moving up/down with mouse movement even though context has swapped to a pop-up prompt and then back to vscode

Expected Interaction

Instead of popping an SVN dialog immediate the plugin should pop a vscode notification in the bottom right that allows the user to later click Yes/No to delete the file from SVN, or in some other way notifies the user that they have a pending removal that needs to be looked at. The current prompt is a forced flow break but it doesn't pop immediately on deletion because the file scanning happens asynchronously.

@Sleaker Sleaker changed the title workspace File deletion prompts for SVN removal breaking any other interactive flow workspace File deletion prompts for SVN removal breaking normal vscode UI flow Mar 1, 2019
@JohnstonCode JohnstonCode self-assigned this Mar 14, 2019
@JohnstonCode
Copy link
Owner

Yeah been using this alot recently. Massvie pain

JohnstonCode added a commit that referenced this issue Mar 15, 2019
JohnstonCode added a commit that referenced this issue Mar 15, 2019
## [1.47.3](v1.47.2...v1.47.3) (2019-03-15)

### Bug Fixes

* Make deletion modal less intrusive ([#498](#498)) ([1585771](1585771)), closes [#487](#487)
@JohnstonCode
Copy link
Owner

🎉 This issue has been resolved in version 1.47.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Sleaker
Copy link
Author

Sleaker commented Mar 18, 2019

Thanks! this appears to be working great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants