Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed .asar file locking (close #437) #539

Merged
merged 1 commit into from
Mar 28, 2019
Merged

fix: Fixed .asar file locking (close #437) #539

merged 1 commit into from
Mar 28, 2019

Conversation

edgardmessias
Copy link
Contributor

@edgardmessias edgardmessias commented Mar 28, 2019 •
edited
Loading

  • Fixed .asar file locking
  • Replaced all usage of "fs" with "original-fs"
  • Blacklisted usage of "fs" module

https://electronjs.org/docs/tutorial/application-packaging#treating-an-asar-archive-as-a-normal-file

@codecov
Copy link

codecov bot commented Mar 28, 2019 •
edited
Loading

Codecov Report

Merging #539 into master will decrease coverage by 0.61%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
- Coverage   57.97%   57.36%   -0.62%     
==========================================
  Files         102      102              
  Lines        4055     4055              
  Branches      581      581              
==========================================
- Hits         2351     2326      -25     
- Misses       1492     1516      +24     
- Partials      212      213       +1
Impacted Files Coverage Δ
src/model.ts 60.51% <ø> (-4.73%) ⬇️
src/treeView/nodes/incomingChangeNode.ts 17.24% <ø> (ø) ⬆️
src/tools/generateConfigSectionForReadme.ts 0% <0%> (ø) ⬆️
src/fs/readdir.ts 42.85% <100%> (ø) ⬆️
src/historyView/common.ts 33.09% <100%> (ø) ⬆️
src/commands/openFile.ts 60.52% <100%> (ø) ⬆️
src/historyView/repoLogProvider.ts 26.87% <100%> (-0.89%) ⬇️
src/fs/stat.ts 42.85% <100%> (ø) ⬆️
src/commands/deleteUnversioned.ts 50% <100%> (ø) ⬆️
src/tempFiles.ts 64.28% <100%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba786a...9ce917c. Read the comment docs.

@edgardmessias edgardmessias changed the title fix: Fixed .asar file locking fix: Fixed .asar file locking (close #437) Mar 28, 2019
JohnstonCode
JohnstonCode approved these changes Mar 28, 2019
View reviewed changes
Copy link
Owner

@JohnstonCode JohnstonCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@JohnstonCode JohnstonCode merged commit 66af99b into JohnstonCode:master Mar 28, 2019
JohnstonCode added a commit that referenced this pull request Mar 28, 2019
@JohnstonCode
chore(release): 1.47.11 [skip ci]
1b24216 
## [1.47.11](v1.47.10...v1.47.11) (2019-03-28)

### Bug Fixes

* Fixed .asar file locking (close [#437](#437)) ([#539](#539)) ([66af99b](66af99b))
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 1.47.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edgardmessias edgardmessias deleted the fix_437_fs_asar branch March 28, 2019 16:24
This was referenced May 6, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnstonCode JohnstonCode JohnstonCode approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edgardmessias @JohnstonCode