Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVN doesn't work with Remote-SSH extension #561

Closed
FractalBoy opened this issue May 5, 2019 · 7 comments · Fixed by #571
Closed

SVN doesn't work with Remote-SSH extension #561

FractalBoy opened this issue May 5, 2019 · 7 comments · Fixed by #571

Comments

@FractalBoy
Copy link
Contributor

  • VSCode Version: 1.34.0-insider
  • OS Version: Windows 10 / RHEL 7
  • Extension Version: 1.48.1
  • System Language: English (US)
  • SVN Version: 1.9.7

Issue

I am using the new Remote-SSH extension. When I try to use the SVN extension with it, it reports that "There is no data provider registered that can provide view data".

I thought that it may be that I have svn installed in /opt/subversion/bin/svn, but I tried setting svn.path to that path, and it still doesn't work.

I also tried setting it to my TortoiseSVN path, in case it needs to use the executable on the Windows side for some reason. That doesn't work either.

In the developer's console, there is an error "Cannot find module 'original-fs'". I don't know if that is related.

Note that Git works fine.

Steps to Reproduce

  1. Install the Remote-SSH extension.
  2. Connect to a Linux system
  3. Attempt to use the SVN extension after opening a path that is using SVN.

SVN Output

None - no option in the dropdown.

Screenshots

image

@FractalBoy
Copy link
Contributor Author

I tested this on just Windows and I do not see the same problem. I also don't see the same error in the developer's console.

@Chuxel
Copy link

Chuxel commented May 6, 2019

VS Code Remote - SSH will run the subversion extension in a remote host that is a standard Node.js runtime instead of Electron.

With this change, the SVN extension now relies on the original-fs node module that is only available inside Electron: #539

To resolve, there's a value passed into extension activation you can use to load fs instead of original-fs when in the remote context. You can also attempt to load original-fs and fall back to fs if it errors.

@JohnstonCode
Copy link
Owner

Thanks @Chuxel Ill get that updated

@edgardmessias
Copy link
Contributor

@JohnstonCode , add this package: https://www.npmjs.com/package/original-fs
A single pollyfill

@ScaredyCat
Copy link

Any movement on this yet?

JohnstonCode added a commit that referenced this issue May 13, 2019
## [1.48.3](v1.48.2...v1.48.3) (2019-05-13)

### Bug Fixes

* Added origional-fs polyfil for remote vs code ([#571](#571)) ([9da6001](9da6001)), closes [#561](#561)
@JohnstonCode
Copy link
Owner

🎉 This issue has been resolved in version 1.48.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@FractalBoy
Copy link
Contributor Author

It works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants