Is remove from changelist feature removed?

[MichaelSuen-thePointer]

Cannot find remove from changelist feature in the right click menu anymore.

Is it removed or moved to other place?

If it is removed, please change this issue to a feature request, I will be grateful.

[edgardmessias]

If file has a changelist, on "Set changelist" has option to remove.

Look:

svn-scm/src/changelistItems.ts

Line 31 in 80743dd

if (canRemove) {

[MichaelSuen-thePointer]

If file has a changelist, on "Set changelist" has option to remove.

Look:

svn-scm/src/changelistItems.ts

Line 31 in 80743dd

if (canRemove) {

Tried, but there's no remove option.

[edgardmessias]

@JohnstonCode, I can't reproduce, working fine here.
@MichaelSuen-thePointer , what you extension version? VSCode?
Go to "Help > Toggle Developers Tools" and check some message

[MichaelSuen-thePointer]

@JohnstonCode, I can't reproduce, working fine here.
@MichaelSuen-thePointer , what you extension version? VSCode?
Go to "Help > Toggle Developers Tools" and check some message

VSCode:
version: 1.33.1 (user setup)
commit: 51b0b28134d51361cf996d2f0a1c698247aeabd8
date: 2019-04-11T08:27:14.102Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.16299

Extension: 1.48.2

After a quick debugging, I found this repository.changelists is just an empty object, wierd.
Where is it initialized?

BTW, every time I left click on the file which has been added to the changelist (like the one below)

an 'oh no' error message appears in the debug console, don't know why.

[JohnstonCode]

Here https://github.com/JohnstonCode/svn-scm/blob/master/src/repository.ts#L575

[edgardmessias]

@MichaelSuen-thePointer, the question is: How the file is in "IGNORE-ON-COMMIT"? You can set another change list and back?

[JohnstonCode]

@edgardmessias I cant reproduce either

[MichaelSuen-thePointer]

@edgardmessias I cant reproduce either

@JohnstonCode, I can't reproduce, working fine here.
@MichaelSuen-thePointer , what you extension version? VSCode?
Go to "Help > Toggle Developers Tools" and check some message

Guys, I found a way to repro the bug:

1. checkout a folder, lets say folder1
2. modify folder1's externals property: add an external entry to another folder, lets say folder2
   
3. commit changes in folder1 and update in folder1 to get folder2 downloaded
4. create a file testfile.txt inside folder1/folder2
5. commit testfile.txt
   
6. set testfile.txt's change list to ignore-on-commit, either in VSCode or in command line is OK
7. back to folder1, open with Code here
8. see what happends
   

[MichaelSuen-thePointer]

@JohnstonCode @edgardmessias
Guys, I found the steps to reproduce the issue above, please have a try.

[JohnstonCode]

Thanks for finding a way to replicate this. Will have a look as soon as i have time.

[JohnstonCode]

🎉 This issue has been resolved in version 1.50.4 🎉

The release is available on:

• Visual Studio Marketplace
• GitHub release

Your semantic-release bot 📦🚀