Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Able to revert folders with children #577

Merged
merged 5 commits into from
May 24, 2019
Merged

fix: Able to revert folders with children #577

merged 5 commits into from
May 24, 2019

Conversation

JohnstonCode
Copy link
Owner

fixes #573

@codecov
Copy link

codecov bot commented May 14, 2019 •
edited
Loading

Codecov Report

Merging #577 into master will decrease coverage by 0.04%.
The diff coverage is 36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
- Coverage   57.69%   57.64%   -0.05%     
==========================================
  Files         111      111              
  Lines        4108     4127      +19     
  Branches      583      585       +2     
==========================================
+ Hits         2370     2379       +9     
- Misses       1526     1536      +10     
  Partials      212      212
Impacted Files Coverage Δ
src/repository.ts 60.87% <0%> (ø) ⬆️
src/svnRepository.ts 53.53% <0%> (ø) ⬆️
src/common/types.ts 100% <100%> (ø) ⬆️
src/commands/revert.ts 34.48% <25%> (-1.89%) ⬇️
src/commands/revertAll.ts 34.48% <25%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 538262f...e7537b4. Read the comment docs.

@edgardmessias
Copy link
Contributor

My idea for now:

  • Create a new argument called "depth"

For future:
In command , when select a folder, show a showQuickPick with all changed folders and files on same structure and allow select multiple (default all selected), like TortoiseSVN

edgardmessias
edgardmessias suggested changes May 15, 2019
View reviewed changes
Copy link
Contributor

@edgardmessias edgardmessias left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a new argument called "depth", and a enum type with values for enum

@JohnstonCode
Copy link
Owner Author

Note to self types should be:
empty - only the target itself
files - the target and any immediate file children thereof
immediates - the target and any immediate children thereof
infinity - the target and all of its descendants—full recursion

edgardmessias
edgardmessias approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@edgardmessias edgardmessias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good deal

@JohnstonCode JohnstonCode merged commit 9bf7683 into master May 24, 2019
@JohnstonCode JohnstonCode deleted the 573 branch May 24, 2019 11:12
JohnstonCode added a commit that referenced this pull request May 24, 2019
@JohnstonCode
chore(release): 1.48.6 [skip ci]
15e9568 
## [1.48.6](v1.48.5...v1.48.6) (2019-05-24)

### Bug Fixes

* Able to revert folders with children ([#577](#577)) ([9bf7683](9bf7683))
@JohnstonCode
Copy link
Owner Author

🎉 This PR is included in version 1.48.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgardmessias edgardmessias edgardmessias approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to revert folders with children
2 participants
@JohnstonCode @edgardmessias