Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag machine specific configurations like paths as machine scoped #613

Closed
sandy081 opened this issue Jun 14, 2019 · 2 comments
Closed

Flag machine specific configurations like paths as machine scoped #613

sandy081 opened this issue Jun 14, 2019 · 2 comments

Comments

@sandy081
Copy link

I am developer from VS Code and we introduced Machine Scope for configurations in 1.34 which will help in remote set ups.

I would like to encourage extension authors to adopt to machine scope if you have any settings that you think they are scoped to machine like svn.path

For example, If you have settings that allow users to customize an executable path that exists on the machine in which extension is running, then you can tag such settings as machine scoped. This will let VS Code to read this setting from the location where the extension is running.

  • When extension is running locally, VS Code reads this setting only from User settings on the same machine.
  • When extension is running remotely, VS Code reads this setting only from Remote settings on the remote machine.

If the extension is running remotely in a remote set up, then this will help the extension not to read paths configured in local machine user settings and bail as the paths not exist in the remote machine.

Note that machine scoped settings are overridable only in user or remote settings.

Please note that you are using isExecutable property for this setting, which is deprecated long time back. Using machine scope is the replacement.

@JohnstonCode
Copy link
Owner

@edgardmessias should this be closed by #614 ?

@edgardmessias
Copy link
Contributor

@JohnstonCode, yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants