Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of proposed API #675

Closed
JohnstonCode opened this issue Oct 4, 2019 · 7 comments · Fixed by #690
Closed

Removal of proposed API #675

JohnstonCode opened this issue Oct 4, 2019 · 7 comments · Fixed by #690
Labels
RFC

Comments

@JohnstonCode
Copy link
Owner

I suggest that anything using the proposed API is removed. My reasoning is that it is Proposed API is a set of unstable API and They are subject to change. Having to hack them to work is also problematic for less knowledgeable people.
@JohnstonCode
Copy link
Owner Author

#632

@JohnstonCode
Copy link
Owner Author

@edgardmessias thoughts?

@JohnstonCode
Copy link
Owner Author

This would be a breaking change and would mean a major version bump

@edgardmessias
Copy link
Contributor

I agree, we can make a special plugin to use only proposed api like: https://github.com/microsoft/vscode/tree/master/extensions/git/src/api
Example: this plugin keep only "stable api" and "svn-scm-proposed" with proposed APIs, but it is a dependent plugin

@JohnstonCode
Copy link
Owner Author

@edgardmessias is the revert in the diff gutter a proposed api?

image

@JohnstonCode JohnstonCode mentioned this issue Oct 22, 2019
Merged
@edgardmessias
Copy link
Contributor

I not remember, but you can check this: https://github.com/microsoft/vscode/blob/313a14265237bc59420bc98c73fbc446b2bf38d1/src/vs/vscode.proposed.d.ts#L581

@JohnstonCode
Copy link
Owner Author

Yeah it will be requires LineChange

JohnstonCode added a commit that referenced this issue Nov 8, 2019
@JohnstonCode
fix: Removed proposed api (#690)
7fb3966 
BREAKING CHANGE: Removed proposed api functionallity (#675)
JohnstonCode added a commit that referenced this issue Nov 8, 2019
@JohnstonCode
chore(release): 2.0.0 [skip ci]
1bc1d9e 
# [2.0.0](v1.54.11...v2.0.0) (2019-11-08)

### Bug Fixes

* Removed proposed api ([#690](#690)) ([7fb3966](7fb3966))

### BREAKING CHANGES

* Removed proposed api functionallity (#675)
This was referenced Nov 14, 2019
Closed
Closed
@edgardmessias edgardmessias mentioned this issue Jul 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: Removal of proposed api JohnstonCode/svn-scm
2 participants
@edgardmessias @JohnstonCode