Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: Removal of proposed api #690

Merged
merged 10 commits into from
Nov 8, 2019
Merged

BREAKING CHANGE: Removal of proposed api #690

merged 10 commits into from
Nov 8, 2019

Conversation

JohnstonCode
Copy link
Owner

fixes #675

@codecov
Copy link

codecov bot commented Oct 22, 2019 •
edited
Loading

Codecov Report

Merging #690 into master will increase coverage by 1.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
+ Coverage   56.36%   57.59%   +1.22%     
==========================================
  Files         117      112       -5     
  Lines        4407     4169     -238     
  Branches      650      624      -26     
==========================================
- Hits         2484     2401      -83     
+ Misses       1685     1541     -144     
+ Partials      238      227      -11
Impacted Files Coverage Δ
src/util.ts 68.18% <ø> (-1.05%) ⬇️
src/common/types.ts 100% <ø> (ø) ⬆️
src/commands.ts 100% <ø> (ø) ⬆️
src/extension.ts 72.94% <ø> (+1.97%) ⬆️
src/resource.ts 48.91% <100%> (-3.43%) ⬇️
src/lineChanges.ts 20% <100%> (ø) ⬆️
src/commands/command.ts 50.51% <100%> (+0.76%) ⬆️
src/commands/revertChange.ts 54.54% <100%> (ø) ⬆️
src/svnContentProvider.ts 50.68% <0%> (-1.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ede0dc...d4b513e. Read the comment docs.

@JohnstonCode
Copy link
Owner Author

Re-add the revert changes stuff and just copy the lineChanges interface for the time being.

@JohnstonCode
Re-added revert commands
a5c7ba1 
Readded Revert commands as they dont directly use the proposed API. They
use LineChange which is just an interface and only use the
'registerDiffInformationCommand' if the method is available.
@JohnstonCode
merged in master
e62df1b
@JohnstonCode
Fixed lint issue and npm security issues
61c13bc
@JohnstonCode
Merge branch 'master' into 675
b4fc577
@JohnstonCode
Removed selected ranges as that uses proposed API
19136d1
@JohnstonCode
Copy link
Owner Author

JohnstonCode commented Nov 4, 2019 •
edited
Loading

CodeFactor is not updating properly. Removed the Revert selected ranges stuff but the normal revert stuff is still present

@JohnstonCode JohnstonCode mentioned this pull request Nov 5, 2019
Closed
edgardmessias
edgardmessias reviewed Nov 8, 2019
View reviewed changes
Copy link
Contributor

@edgardmessias edgardmessias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new version of VSCode (>=1.40) has a support to "Configure Runtime Arguments"

https://code.visualstudio.com/updates/v1_40#_disable-gpu-acceleration

Maybe is a alternative

@JohnstonCode
Copy link
Owner Author

Only a subset of arguments is currently supported

@edgardmessias edgardmessias self-requested a review November 8, 2019 19:18
@JohnstonCode JohnstonCode merged commit 6c88c2d into master Nov 8, 2019
@JohnstonCode JohnstonCode deleted the 675 branch November 8, 2019 19:24
JohnstonCode added a commit that referenced this pull request Nov 8, 2019
@JohnstonCode
fix: Removed proposed api (#690)
7fb3966 
BREAKING CHANGE: Removed proposed api functionallity (#675)
JohnstonCode added a commit that referenced this pull request Nov 8, 2019
@JohnstonCode
chore(release): 2.0.0 [skip ci]
1bc1d9e 
# [2.0.0](v1.54.11...v2.0.0) (2019-11-08)

### Bug Fixes

* Removed proposed api ([#690](#690)) ([7fb3966](7fb3966))

### BREAKING CHANGES

* Removed proposed api functionallity (#675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgardmessias edgardmessias edgardmessias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removal of proposed API
2 participants
@JohnstonCode @edgardmessias