Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop retrieving info of repo root #728

Merged
merged 2 commits into from
Nov 10, 2019

Conversation

FractalBoy
Copy link
Contributor

Currently, if you have just the root of your repository checked out and you use svn update to "checkout" each branch (instead of having multiple checked out branches, e.g.), the extension doesn't correctly show the current branch when looking at the logs. Instead, it shows the logs for the root of the repo, which is not right.

This MR makes svn info run in the workspaceRoot, instead of the repo root.

@FractalBoy FractalBoy changed the title Stop retrieving info of branch root Stop retrieving info of repo root Nov 9, 2019
@JohnstonCode JohnstonCode self-requested a review November 10, 2019 13:33
@JohnstonCode
Copy link
Owner

This will break paths that contain @ #548

@FractalBoy
Copy link
Contributor Author

so i just need to pass something other than this.root to fixPegRevision then...

@FractalBoy
Copy link
Contributor Author

the commit i just made should work...let me know if it's wrong

@JohnstonCode
Copy link
Owner

Yeah, just need to get the current root and use that instead.

Copy link
Owner

@JohnstonCode JohnstonCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@JohnstonCode JohnstonCode changed the title Stop retrieving info of repo root fix: Stop retrieving info of repo root Nov 10, 2019
@JohnstonCode JohnstonCode merged commit 12e584b into JohnstonCode:master Nov 10, 2019
JohnstonCode added a commit that referenced this pull request Nov 10, 2019
## [2.0.1](v2.0.0...v2.0.1) (2019-11-10)

### Bug Fixes

* Stop retrieving info of repo root ([#728](#728)) ([12e584b](12e584b))
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants