Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removed revert confirmation alert (close #395) #396

Merged
merged 1 commit into from
Oct 25, 2018
Merged

fix: Removed revert confirmation alert (close #395) #396

merged 1 commit into from
Oct 25, 2018

Conversation

edgardmessias
Copy link
Contributor

  • Removed revert confirmation alert
  • Fixed menu for revert selection in diff editor
  • Fixed register command when diff is true

@codecov
Copy link

codecov bot commented Oct 25, 2018 •
edited
Loading

Codecov Report

Merging #396 into master will increase coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
+ Coverage   61.83%   61.94%   +0.11%     
==========================================
  Files         170      170              
  Lines        7195     7182      -13     
  Branches     1361     1359       -2     
==========================================
  Hits         4449     4449              
+ Misses       2742     2729      -13     
  Partials        4        4
Impacted Files Coverage Δ
src/commands/command.ts 61.42% <0%> (+1.7%) ⬆️
out/commands/command.js 62.38% <0%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d67ba4...46e6252. Read the comment docs.

@JohnstonCode JohnstonCode merged commit 4dce3c9 into master Oct 25, 2018
@JohnstonCode JohnstonCode deleted the revert_confirmation branch October 25, 2018 17:08
JohnstonCode added a commit that referenced this pull request Oct 25, 2018
@JohnstonCode
chore(release): 1.44.3 [skip ci]
a7e8adf 
## [1.44.3](v1.44.2...v1.44.3) (2018-10-25)

### Bug Fixes

* Removed revert confirmation alert (close [#395](#395)) ([#396](#396)) ([4dce3c9](4dce3c9))
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 1.44.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnstonCode JohnstonCode JohnstonCode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edgardmessias @JohnstonCode