checking for lock field when parsing xml entries #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
==========================================
+ Coverage 56.38% 56.42% +0.04%
==========================================
Files 117 117
Lines 4402 4402
Branches 649 649
==========================================
+ Hits 2482 2484 +2
Misses 1685 1685
+ Partials 235 233 -2
Continue to review full report at Codecov.
|
JohnstonCode
requested review from
edgardmessias and
JohnstonCode
and removed request for
edgardmessias
|
@Sergi0 is there ever a senario where the lock object is present and the |
|
@JohnstonCode <entry
path="somefile.cpp">
<wc-status
item="normal"
revision="700"
props="normal">
<commit
revision="600">
<author>dev</author>
<date>2019</date>
</commit>
</wc-status>
<repos-status
item="none"
props="none">
<lock>
<token>opaquelocktoken:</token>
<owner>sysadmin</owner>
<comment>my files</comment>
<created>2019</created>
</lock>
</repos-status>
</entry> |
JohnstonCode
added a commit
that referenced
this pull request
Oct 28, 2019
## [1.54.7](v1.54.6...v1.54.7) (2019-10-28) ### Bug Fixes * checking for lock field when parsing xml entries ([#693](#693)) ([5cb1413](5cb1413))
|
🎉 This PR is included in version 1.54.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock status was not properly recognized when 'lock' object was present in the status response from the server.
Doesn't implement #624, but helps with the locks issue mentioned there.