Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary burner state updates #10

Closed
wants to merge 2 commits into from

Conversation

arjanwaard
Copy link

No description provided.

Rewrote logic on burner state changes to prevent unneeded updates
Change debug message on burner state update
@JohnvandeVrugt
Copy link
Owner

Hi Arjan,

your commit seems to be valid, however, I'm currenty working on a complete rework of the plugin.
In that code, if I'm not mistaken, each device checks its own previous value before updating domoticz.
I expect to release this rework in the coming days...

@arjanwaard
Copy link
Author

arjanwaard commented Mar 13, 2019 via email

@darkrain-nl
Copy link
Contributor

Hi Arjan,

your commit seems to be valid, however, I'm currenty working on a complete rework of the plugin.
In that code, if I'm not mistaken, each device checks its own previous value before updating domoticz.
I expect to release this rework in the coming days...

Hi @JohnvandeVrugt ,

If you need someone to test the rewritten code other then yourself, just let me know.
Or just create a beta branch or something like that.

I'm happy to help and don't mind to do some bugfixing (as far as I can, still not a Python guru).

@arjanwaard
Copy link
Author

Closed waiting for the refactoring

@arjanwaard arjanwaard closed this Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants