Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest v3 #11

Merged
merged 13 commits into from
Aug 24, 2022
Merged

Manifest v3 #11

merged 13 commits into from
Aug 24, 2022

Conversation

JohnyP36
Copy link
Owner

Any additions, changes or removals is at the Authors discretion.
You're free to counterargue (to a certain point) if you disagree with the decision.
To avoid being banned, don't constantly re-open or create new (related) issue reports or pull requests.

Prerequisites

  • I've read the Code of Conduct and the Contributing Guidelines
  • This is more than one or two issue(s)
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • Other webextensions related to Youtube are disabled
    • using a new, unmodified browser profile
  • I am running the latest version of the extension

Describe the issue

I updated the extension to manifest version 3, which Google will implement in January 2023.

Screenshot(s)

Screenshot(s)

Browser & Extension version

Browser name & version Extension Version Operating System
`MS Edge 104` `1.6.5` `Windows 10, 21H2`

Notes

Still not working properly are the loop function and the autoplay in YouTube Music

@JohnyP36
Add files via upload
4ca7f62
@JohnyP36
Update README.md
444fbdf
@JohnyP36
Add info
2a30b2f
@JohnyP36
Removed <script src="js/script.js"></script>
87d50a1 
Solved the same issue as BPower0036 had in Nomes77/YT-Nonstop#8
@JohnyP36
Simplified chrome.runtime.onInstalled.addListener
c570545
@JohnyP36
Reordered, so it's more logic & add incognito: split
bd8c135
@JohnyP36
Add on.Startup
f31af17 
In manifest v2 `chrome.runtime.onInstalled.addListener` was enough to make the popup disable on every domain except YouTube. 
In version 3 I had to add `onStartup` so it will not only disable the popup on installation, but also after restarting your browser.
@JohnyP36
Add functionality for http
ba33204
@JohnyP36
Changed function / const to var
e54580c 
`function loadPageAccess()` didn't work (the script didn't get loaded. 
In order to create a unity I constructed the whole script in this way using `var`.
@JohnyP36
Fixed wrong syntax
14bc986
@JohnyP36
Fixed error with syntax
e693278 
Forgot to change those => should be the same as the word after `var`.
@JohnyP36
Update NOTICE
87a7d87
@JohnyP36
Update year
7d2425a
@JohnyP36 JohnyP36 linked an issue Aug 24, 2022 that may be closed by this pull request
Migration to Manifest v3 #10
Closed
5 tasks
@JohnyP36 JohnyP36 merged commit a44e036 into main Aug 24, 2022
@JohnyP36 JohnyP36 deleted the manifest_v3 branch August 24, 2022 15:47
@JohnyP36 JohnyP36 restored the manifest_v3 branch August 24, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration to Manifest v3
1 participant
@JohnyP36