Add support for MoveFunds action #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubcolony
changed the base branch from
port/create-domain-action
to
port/unlock-token-action
rdig
approved these changes
Feb 26, 2023
| toPot, | ||
| } = event.args; | ||
|
|
||
| const colonyClient = await networkClient.getColonyClient(colonyAddress); |
There was a problem hiding this comment.
I wonder if we could optimize the ingestor somewhat if we were to store all known instances of the colony client.
I see us re-instantiating the client for a lot of tracked events.
But I actually don't know what this impact would be real-life.
willm30
approved these changes
Mar 2, 2023
| const isSupportedColonyClient = ( | ||
| colonyClient: AnyColonyClient, | ||
| ): colonyClient is SupportedColonyClient => | ||
| (colonyClient as SupportedColonyClient).getDomainFromFundingPot !== undefined; |
There was a problem hiding this comment.
alternatively:
'getDomainFromFundingPot' in colonyClientThen you don't need to cast colonyClient
There was a problem hiding this comment.
I think explicit casting might be better here since it will alert you if the property you're checking against doesn't exist/got removed
https://www.typescriptlang.org/docs/handbook/2/narrowing.html#using-type-predicates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a parallel PR to JoinColony/colonyCDapp#291
Please refer to that PR for testing instructions