Cache colony clients #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julianahlk
approved these changes
Mar 24, 2023
rdig
approved these changes
Mar 26, 2023
| * Method attempting to return a cached colony client, | ||
| * or get one from the networkClient if there's no cached entry | ||
| */ | ||
| export const getCachedColonyClient = async ( |
There was a problem hiding this comment.
This is a very good start and I like your approach.
But for future improvements I would extend this to also be able to fetch/cache all types of contract clients: network, colony, tokens, but more important extensions.
There was a problem hiding this comment.
Thanks for the suggestions. I thought about doing it in this PR, but here's what I'm proposing we do instead:
- Network client - for now, it looks like
networkClient.tsinstantiates the client once and exports the same instance everywhere; This will only need to be addressed when we support multi-chain - Token client - opened Add token clients caching #43, I know Will is refactoring how we get different types of client and I don't want to make his life harder by introducing more changes
- Extensions client - opened Add extensions client caching #44, this is "blocked" by Will's motion work (nothing else uses extension clients)
Track past actions
This was referenced Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds caching of colony clients. It was originally suggested by Raul in one of my PRs and it made sense to do it now as I found myself calling
getColonyClientin different methods for the same colonyResolves #25