Handle Permissions Events #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdig
added a commit
to JoinColony/colonyCDapp
that referenced
this pull request
Apr 24, 2023
rdig
force-pushed
the
feature/handle-permissions-events
branch
from
f412c1c
to
6e27254
Compare
rdig
added a commit
to JoinColony/colonyCDapp
that referenced
this pull request
Apr 24, 2023
jakubcolony
approved these changes
Apr 24, 2023
willm30
reviewed
Apr 25, 2023
willm30
reviewed
Apr 25, 2023
willm30
reviewed
Apr 25, 2023
willm30
reviewed
Apr 25, 2023
willm30
reviewed
Apr 25, 2023
willm30
reviewed
Apr 25, 2023
willm30
reviewed
Apr 25, 2023
willm30
reviewed
Apr 25, 2023
willm30
reviewed
Apr 25, 2023
willm30
reviewed
Apr 25, 2023
willm30
reviewed
Apr 25, 2023
willm30
reviewed
Apr 25, 2023
There was a problem hiding this comment.
My main question is what is the advantage of processing all RoleSet events in a given block at once, instead of processing them individually? I feel like the batch processing approach adds some complexity compared to making db mutatations on a per event basis (assuming we can link ColonyRoleSet events to their respective ColonyRole and ColonyAction db entries)
rdig
added a commit
to JoinColony/colonyCDapp
that referenced
this pull request
May 2, 2023
Gather data from all events that might be emmited inside a single block, and just do a big update all at once
rdig
force-pushed
the
feature/handle-permissions-events
branch
from
a11e110
to
27085f2
Compare
jakubcolony
pushed a commit
to JoinColony/colonyCDapp
that referenced
this pull request
May 23, 2023
rdig
added a commit
to JoinColony/colonyCDapp
that referenced
this pull request
May 23, 2023
|
As with it's CDapp counterpart, this has been rebased, tested, and it's ready for re-review/merge. As with that one, the more time consuming changes that were pointed out were extracted into a separate issue: #79 This was done in the interest of time, as to get this merged faster, and push forward towards production deployment. |
jakubcolony
approved these changes
May 24, 2023
rdig
force-pushed
the
feature/handle-permissions-events
branch
from
20ea486
to
da0b79a
Compare
rdig
force-pushed
the
feature/handle-permissions-events
branch
from
da0b79a
to
66016f9
Compare
jakubcolony
pushed a commit
to JoinColony/colonyCDapp
that referenced
this pull request
May 31, 2023
rdig
added a commit
to JoinColony/colonyCDapp
that referenced
this pull request
Jun 1, 2023
rdig
force-pushed
the
feature/handle-permissions-events
branch
2 times, most recently
from
2bead94
to
8c80a84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in logic to handle listening to permissions role events, create database entries for them, create historic entries, and finally create permissions actions.
To test this head on over to the CDapp and test the JoinColony/colonyCDapp#271
Some of the logic required gets pretty harry, and so I've left a bunch of comments all over the place. Please make sure to give them a read, to understand the flow of data through the ingestor.