Track colony versions in the database #163
Conversation
jakubcolony
changed the title
| @@ -39,6 +39,8 @@ const ExtensionActionButton = ({ extensionData }: Props) => { | |||
| ); | |||
| }; | |||
|
|
|||
| const isSupportedColonyVersion = colony.version >= 5; | |||
There was a problem hiding this comment.
There used to be a ColonyVersion enum exported from colony-js but it's not there anymore. Open to suggestions on replacing the hardcoded value
There was a problem hiding this comment.
I'd say have a constant
const MIN_SUPPORTED_COLONY_VERSION = 5
const isSupportedColonyVersion = colony.version >= MIN_SUPPORTED_COLONY_VERSION;or similar
| @@ -39,6 +39,8 @@ const ExtensionActionButton = ({ extensionData }: Props) => { | |||
| ); | |||
| }; | |||
|
|
|||
| const isSupportedColonyVersion = colony.version >= 5; | |||
There was a problem hiding this comment.
I'd say have a constant
const MIN_SUPPORTED_COLONY_VERSION = 5
const isSupportedColonyVersion = colony.version >= MIN_SUPPORTED_COLONY_VERSION;or similar
|
|
||
| const extensionCompatible = isExtensionCompatible( | ||
| Extension[extensionData.extensionId], | ||
| extensionData.availableVersion as ExtensionVersion, | ||
| 10, | ||
| (extensionData.availableVersion + 1) as ExtensionVersion, |
There was a problem hiding this comment.
How come we're checking if availableVersion + 1 is compatible? Isn't availableVersion the latest version in the db (i.e. latest + 1 doesn't exist)?
There was a problem hiding this comment.
Good spot, my bad!
| @@ -230,6 +230,7 @@ const createMetacolony = async (singerOrWallet) => { | |||
| name: 'meta', | |||
| profile: { displayName: 'Metacolony' }, | |||
| type: 'METACOLONY', | |||
| version: BigNumber.from(metacolonyVersion).toNumber() | |||
There was a problem hiding this comment.
BigNumber.from...toNumber() could live as a little utility e.g.
numbers.ts
const toNumber = (bigNumber) => BigNumber.from(bigNumber).toNumber()
| @@ -304,6 +305,7 @@ function* colonyCreate({ | |||
| name: givenColonyName, | |||
| colonyNativeTokenId: tokenAddress, | |||
| profile: { displayName }, | |||
| version: BigNumber.from(currentColonyVersion).toNumber(), | |||
There was a problem hiding this comment.
Now that we're storing currentColonyVersion in the db, we should probably also retreive it from there too instead of from the chain? On the basis that it is presumably faster to query the db.
There was a problem hiding this comment.
I'm thinking that this would be covered by #179
Description
This PR adds support for tracking colony version in the block-ingestor. See block-ingestor#4 for details and testing.
Summary of CDapp changes:
versionfield on Colony modelitemfield of CurrentVersion model tokeyto avoid confusion withitemsversionfield to all existing create colony mutationsisSupportedColonyVersionchecks to extensionsResolves #102